Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup deployment to Github Package Registry for nupkg artifact examples #25

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Setup deployment to Github Package Registry for nupkg artifact examples #25

merged 1 commit into from
Oct 26, 2020

Conversation

j4ckofalltrades
Copy link
Contributor

@j4ckofalltrades j4ckofalltrades commented Oct 24, 2020

Refs strongbox/strongbox#1927

Deploys nupkg artifacts generated by nuget-chocolatey and nuget-mono examples. I got it to work using the actions/setup-dotnet@v1.

Sample artifacts:

I also tried using the strongboxci docker images for both but ran into issues:

@j4ckofalltrades
Copy link
Contributor Author

j4ckofalltrades commented Oct 24, 2020

@carlspring Requesting review

Copy link
Member

@carlspring carlspring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you very much!

@carlspring
Copy link
Member

carlspring commented Oct 24, 2020

I think we need to update something in the scripts in order to fix this:
image

Any idea what we're missing?

Also, any idea why the asset for both is called package.nupkg?
image

@j4ckofalltrades
Copy link
Contributor Author

Any idea what we're missing?

The description tag for the .nuspec file in the hello-chocolatey example had placeholder values, along with some other metadata. I've updated them and added a link to the .nuspec File Reference docs

Also, any idea why the asset for both is called package.nupkg?

Hmm not sure if this a nuget or GitHub Package Registry thing. From what I can see in the logs, nuget doesn't seem to be renaming the artifact:

Pushing hello-chocolatey.1.0.0.nupkg to 'https://nuget.pkg.github.com/strongbox'...
PUT https://nuget.pkg.github.com/strongbox/

@carlspring
Copy link
Member

Thanks for fixing the placeholders! :)
This looks good to me now.

@carlspring
Copy link
Member

Could you please rebase this, so we can merge it? Thanks! ;)

@j4ckofalltrades
Copy link
Contributor Author

@carlspring Merge conflicts resolved

@carlspring carlspring merged commit 874ec34 into strongbox:master Oct 26, 2020
@j4ckofalltrades j4ckofalltrades deleted the issue-1927-nuget-examples branch October 26, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants