Setup deployment to GitHub package registry for Gradle artifacts #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@carlspring Requesting review |
carlspring
reviewed
Oct 25, 2020
carlspring
reviewed
Oct 25, 2020
hello-strongbox-gradle/build.gradle
Outdated
Comment on lines
23
to
26
| username = project.findProperty("gpr.user") ?: System.getenv("GITHUB_USERNAME") | ||
| password = project.findProperty("gpr.key") ?: System.getenv("GITHUB_TOKEN") |
There was a problem hiding this comment.
Do we need to have Github secrets defined for these?
There was a problem hiding this comment.
No, GITHUB_USERNAME is sourced from actions/setup-java while GITHUB_TOKEN is automatically set by GitHub for each repository.
I'll document this here.
There was a problem hiding this comment.
Excellent, thank you very much! :)
It might be worth mentioning all this in the master task for future reference.
There was a problem hiding this comment.
Yeah that's a good idea. I'll drop in a comment there.
carlspring
reviewed
Oct 25, 2020
carlspring
reviewed
Oct 25, 2020
carlspring
reviewed
Oct 25, 2020
carlspring
requested changes
Oct 25, 2020
carlspring
reviewed
Oct 25, 2020
carlspring
approved these changes
Oct 25, 2020
|
Thanks for your help! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs strongbox/strongbox#1927
Published artifact: https://github.com/j4ckofalltrades/strongbox-examples/packages/472460?version=1.0-SNAPSHOT
Note: Not sure if adding a description to artifact is possible at this time, I read through the maven-publish and GitHub docs but couldn't find anything.