Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hello-strongbox-maven #28

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

BjoernAkAManf
Copy link

@BjoernAkAManf
Copy link
Author

I got caught up in some work today, so i didnt get to finish implementing your suggestions. Will do it tomorrow.

@BjoernAkAManf
Copy link
Author

I fixed the outstanding issues.

However i cannot seem to push a package right now (see https://www.rushworth.us/lisa/?p=6239 )

Comment on lines +83 to +84
# This is seperate so it may only be deployed conditionally
- name: Maven deploy

This comment was marked as resolved.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually leave it as it is right now. It might be useful for branch deploys / testing.

@steve-todorov
Copy link
Member

However i cannot seem to push a package right now (see https://www.rushworth.us/lisa/?p=6239 )

Hmm... yeah that sounds like the issue @j4ckofalltrades and @carlspring mentioned. I guess the only way to fix it in the current moment would be to increment the versions for each project before merging a PR.

@carlspring
Copy link
Member

carlspring commented Oct 29, 2020

Yes, unfortunately... (Unless, you'd like to raise a support ticket with Github each time you'd like to test it).
We can revert the version when you're ready to have it merged.

@BjoernAkAManf
Copy link
Author

It should be ready right now, shouldn't it?
Not sure what to improve or change. (Conditional deploys aren't wanted right now).

@carlspring
Copy link
Member

Hi, @BjoernAkAManf !

Thank you for your contribution!

Would you mind signing the ICLA, as described in the Contributing page?

Also, please, feel free to join our chat channel, if you'd like to learn more about the project and/or like to find out what else you could help with.

Kind regards,

Martin

@BjoernAkAManf
Copy link
Author

Done 😄 .

I'll keep a look at the Chat(, as I desperately need to update my Tech Stack to a fully self hosted one 😛 ).

Copy link
Member

@carlspring carlspring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks! :)

Copy link
Contributor

@j4ckofalltrades j4ckofalltrades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@carlspring
Copy link
Member

carlspring commented Oct 29, 2020

Great! I will not merge this yet, because there's another global problem with the deployment of these example artifacts (it's applicable for all the supported tools). Please, check my comment in the master task ( strongbox/strongbox#1927 ).

@steve-todorov
Copy link
Member

@carlspring maybe we can approach the issue here the same way as @j4ckofalltrades suggested in his comment ?

@carlspring
Copy link
Member

I agree. @BjoernAkAManf , could you please look into this?

Thanks! 👍

@BjoernAkAManf
Copy link
Author

I'll have a look this weekend :). unfortunately quite busy this week.

@BjoernAkAManf
Copy link
Author

So i added the workaround by @j4ckofalltrades which was not that hard, considering all the hard work already done 👍
However, i feel like in my fork that workaround is still not allowing me to push to the repository. Maybe I'm doing something wrong? GPR can sometimes be really weird in behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants