Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply consistent naming to example artifacts #29

Merged
merged 1 commit into from
Nov 7, 2020
Merged

Apply consistent naming to example artifacts #29

merged 1 commit into from
Nov 7, 2020

Conversation

j4ckofalltrades
Copy link
Contributor

All generated artifacts now follow the format
'hello-strongbox-[tool-goes-here]`.

Refs strongbox/strongbox#1927

All generated artifacts now follow the format
'hello-strongbox-[tool-goes-here]`.

Refs strongbox/strongbox#1927
@@ -4,7 +4,7 @@
long_description = fh.read()

setup(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From Python Packaging docs:

name is the distribution name of your package. This can be any name as long as only contains letters, numbers, _ , and -. It also must not already be taken on pypi.org. Be sure to update this with your username, as this ensures you won’t try to upload a package with the same name as one which already exists when you upload the package.

packages is a list of all Python import packages that should be included in the Distribution Package.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this clarification, @j4ckofalltrades .

cc: @steve-todorov , @anki2189

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pinging me!

cc: @sbespalov in case you don't already know this. :)

Copy link
Member

@steve-todorov steve-todorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you very much for making things more consistent! :)

@carlspring
Copy link
Member

Thanks for your help! :)

@j4ckofalltrades j4ckofalltrades deleted the issue-1927-update-example-pkg-names branch November 8, 2020 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants