Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport the fixes related to replacing ApacheDS with UnboundID from pull #1783 to the master #1846 And Upgrade our UnboundID dependencies from 4.0.9 to 5.1.1 #1858 #113

Merged
merged 2 commits into from
Oct 19, 2020

Conversation

mknutsen79
Copy link
Contributor

@mknutsen79 mknutsen79 commented Oct 18, 2020

Pull Request Description

Due to a commit issue on original branch issue-1846 (the latest commit was removing updates from the strongbox-parent's master with pervious now out-of-date versions) a second branch was made in order to keep the proper formatting of the file and include the updates for the two listed issues.

This pull request closes strongbox/strongbox#1846 and supercedes #105. The associates with strongbox/strongbox#1908.
It also relates to strongbox/strongbox#1783 and strongbox/strongbox#1909.

Acceptance Test

  • Building the code of the strongbox-parent with mvn clean install still works.
  • Building the code of the strongbox project with mvn clean install -Dintegration.tests still works.
  • Running mvn spring-boot:run in the strongbox-web-core still starts up the application correctly.
  • Building the code and running the strongbox-distribution from a zip or tar.gz still works.
  • The tests in the strongbox-web-integration-tests still run properly.

Questions

  • Does this pull request break backward compatibility?

    • Yes
    • No
  • Does this pull request require other pull requests to be merged first?

    • Yes, please see #...
    • No
  • Does this require an update of the documentation?

    • Yes, please see strongbox/strongbox-docs#{PR_NUMBER}
    • No

Code Review And Pre-Merge Checklist

  • My code follows the coding convention of this project.
  • I have performed a self-review of my own code.
  • I have commented my code in hard-to-understand areas.
  • My changes generate no new warnings.

@carlspring carlspring changed the title (Properly updated)Backport the fixes related to replacing ApacheDS with UnboundID from pull #1783 to the master #1846 And Upgrade our UnboundID dependencies from 4.0.9 to 5.1.1 #1858 Backport the fixes related to replacing ApacheDS with UnboundID from pull #1783 to the master #1846 And Upgrade our UnboundID dependencies from 4.0.9 to 5.1.1 #1858 Oct 19, 2020
Copy link
Member

@carlspring carlspring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your help! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants