Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed test mock instance management for RemoteRepositoryAlivenessCacheManager #1672

Merged
merged 1 commit into from Feb 6, 2020

Conversation

sbespalov
Copy link
Member

@sbespalov sbespalov commented Feb 6, 2020

Pull Request Description

This pull request closes #1671

Acceptance Test

  • Building the code with mvn clean install -Dintegration.tests still works.
  • Running mvn spring-boot:run in the strongbox-web-core still starts up the application correctly.
  • Building the code and running the strongbox-distribution from a zip or tar.gz still works.
  • The tests in the strongbox-web-integration-tests still run properly.

Questions

  • Does this pull request break backward compatibility?

    • Yes
    • No
  • Does this pull request require other pull requests to be merged first?

    • Yes, please see #...
    • No
  • Does this require an update of the documentation?

    • Yes, please see strongbox/strongbox-docs#{PR_NUMBER}
    • No

`RemoteRepositoryAlivenessCacheManager`
@ghost
Copy link

ghost commented Feb 6, 2020

DeepCode's analysis on #6cbd02 found:

  • 0 critical issues. ⚠️ 0 warnings and 1 minor issue. ✔️ 0 issues were fixed.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.


☺️ If you want to provide feedback on our bot, here is how to contact us.

@steve-todorov steve-todorov merged commit 25422b5 into strongbox:master Feb 6, 2020
@steve-todorov
Copy link
Member

Thanks for fixing this @sbespalov ! :)

@carlspring
Copy link
Member

@sbespalov :

Was this the same problem as #1513 ?

@carlspring carlspring deleted the issues/1671 branch February 7, 2020 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate and fix randomly failing tests
3 participants