Multipart File size config properties #1822
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlspring
reviewed
Aug 12, 2020
| @@ -6,6 +6,8 @@ spring: | |||
| servlet: | |||
| multipart: | |||
| enabled: true | |||
| max-file-size: 1MB | |||
There was a problem hiding this comment.
Default value is 1 MB , so in order to have default behaviour kept this as 1MB.
There was a problem hiding this comment.
Can you check, if this property can be disabled, if you set it to 0, or -1, or does it need an actual value?
There was a problem hiding this comment.
-1 will be treated as unlimited.
There was a problem hiding this comment.
Quick question - can we use a proxy value for this? Maybe ${strongbox.max-file-size} and ${strongbox.max-request-size} which are actually configured in strongbox.yaml? :)
I think this value can overwritten if you export an env var SPRING_SERVLET_MAX_FILE_SIZE || SPRING_SERVLET_MAX_REQUEST_SIZE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This pull request closes #1819
Acceptance Test
mvn clean install -Dintegration.testsstill works.mvn spring-boot:runin thestrongbox-web-corestill starts up the application correctly.strongbox-distributionfrom aziportar.gzstill works.strongbox-web-integration-testsstill run properly.Questions
Does this pull request break backward compatibility?
Does this pull request require other pull requests to be merged first?
Does this require an update of the documentation?