Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use openjdk8 for travis-ci macOS build #1959

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Use openjdk8 for travis-ci macOS build #1959

merged 1 commit into from
Nov 17, 2020

Conversation

j4ckofalltrades
Copy link
Contributor

@j4ckofalltrades j4ckofalltrades commented Nov 15, 2020

@steve-todorov

I've fixed the failing integration tests in #1958 by replacing the remote url from repo.spring.io to jcenter.bintray.com as recommended by @carlspring.

Travis CI build: https://travis-ci.org/github/j4ckofalltrades/strongbox/jobs/743752372

Pull Request Description

This pull request closes #1956
This pull request also closes #1958

Acceptance Test

  • Building the code with mvn clean install -Dintegration.tests still works.
  • Running mvn spring-boot:run in the strongbox-web-core still starts up the application correctly.
  • Building the code and running the strongbox-distribution from a zip or tar.gz still works.
  • The tests in the strongbox-web-integration-tests still run properly.

Questions

  • Does this pull request break backward compatibility?

    • Yes
    • No
  • Does this pull request require other pull requests to be merged first?

    • Yes, please see #...
    • No
  • Does this require an update of the documentation?

    • Yes, please see strongbox/strongbox-docs#{PR_NUMBER}
    • No

Code Review And Pre-Merge Checklist

  • My code follows the coding convention of this project.
  • I have performed a self-review of my own code.
  • I have commented my code in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Copy link
Member

@carlspring carlspring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for these fixes! :)

@carlspring
Copy link
Member

@j4ckofalltrades ,

The build seems to still be failing under Travis. Would you mind having another look? Thanks! :)

Copy link
Member

@steve-todorov steve-todorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for spending the time to fix this!

@steve-todorov steve-todorov merged commit 29f3f0b into strongbox:master Nov 17, 2020
@j4ckofalltrades j4ckofalltrades deleted the jdk8-version-upgrade-travisci branch November 17, 2020 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MavenProxyRepositoryProviderTestIT failing test cases Upgrade Travis CI to use JDK 8 >= 222
3 participants