Issue 1818: Improve our checksum support for Maven metadata

[sainalshah]

Pull Request Description

This pull request closes #1818

Acceptance Test

• Building the code with mvn clean install -Dintegration.tests still works.
• Running mvn spring-boot:run in the strongbox-web-core still starts up the application correctly.
• Building the code and running the strongbox-distribution from a zip or tar.gz still works.
• The tests in the strongbox-web-integration-tests still run properly.

Questions

• Does this pull request break backward compatibility?

  • Yes
  • No

• Does this pull request require other pull requests to be merged first?

  • Yes, please see Issue 1818: Add support for SHA-256 and SHA-512 carlspring/commons-io#7, Issue 1818: Improve our checksum support for Maven metadata strongbox-web-ui#49
  • No

• Does this require an update of the documentation?

  • Yes, please see strongbox/strongbox-docs#{PR_NUMBER}
  • No

Code Review And Pre-Merge Checklist

• My code follows the coding convention of this project.
• I have performed a self-review of my own code.
• I have commented my code in hard-to-understand areas.
• My changes generate no new warnings.
• I have added tests that prove my fix is effective or that my feature works.
• New and existing unit tests pass locally with my changes.

[carlspring]

@sainalshah ,

Thanks for you help! Could you please follow our coding convention and go over your code and apply the necessary changes? I've flagged a few, but there are more and I'm sure you'll spot them once you've had a look at our coding convention and installed the respective code style files.

I'll have another look, when you've applied these. Thanks! :)

[sainalshah]

@carlspring As we discussed on chat, I have removed the code for global repository configuration both from strongbox and strongbox-web-ui projects.

The compilation on Jenkins is failing because it cannot find the updated carlspring/commons-io artifiact. I'm not sure about the practice here, would you be making a new release for carlspring/commons-io with the latest changes?

[carlspring]

@sainalshah ,

You need to create a new pull request against the strongbox-parent and change the version of the commons-io there. Then you need to update the current pull request to use that version of the parent. If it works,

• @steve-todorov : Could you please cut a release of carlspring/commons-io and deploy it to Maven Central
• @sainalshah :
  • Close the pull request for the strongbox-parent.
  • Revert the current pull request to strongbox-parent:1.0.