Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-840: Create an RPM distribution #855

Closed
wants to merge 6 commits into from

Conversation

v3rtumnus
Copy link
Contributor

Fixes #840

@v3rtumnus v3rtumnus changed the title Issue-840: Create an RPM distribution Issue-840: Create an RPM distribution [in progress] Oct 8, 2018
@v3rtumnus v3rtumnus changed the title Issue-840: Create an RPM distribution [in progress] Issue-840: Create an RPM distribution Oct 17, 2018
@v3rtumnus
Copy link
Contributor Author

Added the creation of the RPM file and also a service file, as well as a postinstall script to create the relevant user and group.

@v3rtumnus
Copy link
Contributor Author

@steve-todorov Hi, I think you are the right person for my question: Seems like the Jenkins build fails because rpm is not installed on the relevant machine. Can I fix that or could you do that?

@steve-todorov
Copy link
Member

rpm and dpkg-dev have been added to our alpine images 👍

@carlspring
Copy link
Member

In this line of thought, would it be possible to add apt and aptitude as well for the similar task for creating Debian distributions?

@carlspring
Copy link
Member

@steve-todorov ,

Could you please try this out and give some feedback?

@@ -0,0 +1,3 @@
groupadd strongbox
useradd -d /usr/local/strongbox -g strongbox strongbox
chown -R strongbox:strongbox /usr/local/strongbox/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, make sure you add new lines to the end of files when creating, or editing them, as this can sometimes be a problem on different operating systems.

@carlspring
Copy link
Member

@v3rtumnus , @steve-todorov :

Once this task is done, I think it would be a good idea to go over the Installation Guide and update it as necessary.

Things will then need to be tested based on the instructions.

@@ -0,0 +1,3 @@
groupadd strongbox
useradd -d /usr/local/strongbox -g strongbox strongbox
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be a regular user but rather a system one. Could you please add --system here?

Suggested change
useradd -d /usr/local/strongbox -g strongbox strongbox
useradd -d /usr/local/strongbox -g strongbox --system strongbox

@steve-todorov
Copy link
Member

The produced RPM does not work out of the box in opensuse leap 15 just yet.

Strongbox expects to be able to write into $STRONGBOX_VAULT which currently is $STRONGBOX_HOME/../strongbox-vault. What this mean in this case is /usr/local/strongbox-vault. That path does not exist and in most cases on SELinux distributions you would not be able to write there to begin with (unless you have manually configured it).

By convention databases are usually stored in /var/lib/product-name and I think we should do it the same (thoughts @carlspring?). We should probably create an /etc/sysconfig/strongbox file which contains the STRONGBOX_VAULT environment variable that points to /var/lib/strongbox.
This would be the same for Debian, only the path for the file would be /etc/default/strongbox.

@carlspring
Copy link
Member

carlspring commented Feb 24, 2019

Closing this in favour of the rebased version of this branch in #1068.

@carlspring carlspring closed this Feb 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants