Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Refactor grantbot's name, helper methods and collaborators instantiation #16

Closed
camposer opened this issue Apr 5, 2021 · 0 comments · Fixed by #17
Closed

Refactor grantbot's name, helper methods and collaborators instantiation #16

camposer opened this issue Apr 5, 2021 · 0 comments · Fixed by #17
Labels
refactoring Refactor, remember not to change behaviour

Comments

@camposer
Copy link
Contributor

camposer commented Apr 5, 2021

Is your refactoring related to a problem? Please describe.
The grantbot class has several pending improvements in order to make it easier to read.

  • Name. The project name changed from grantbot to accessbot, but that's not reflected in the code yet
  • Helper methods. The class is the core of the project, and all the logic there makes it hard to read
  • Collaborators instantiation. Singleton methods implementation on the different collaborator files is ugly and can be avoided.

Describe the solution you'd like

  • Name. Change the name of the project and validate tests
  • Helper methods. Create separate class for each different command
  • Collaborators instantiation. Remove singletons and transfer responsibility to the accessbot class
@camposer camposer added the refactoring Refactor, remember not to change behaviour label Apr 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
refactoring Refactor, remember not to change behaviour
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant