Support static seed publishing #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Glob patterns expand to what they match, which makes them useless for creating things that don't yet exist.
By putting a multi-version file at /tmp/npm/store/<pkgname>/package.json you can effectively lock a package to a given selection of versions for the lifetime of the npm registry. This file should be analogous to what would normally be served up at https://registry.npmjs.org/<pkgname>
Read input from STDIN on startup. If it is a tgz file, then assume it is a node package as produced by `npm pack`. Read that tarball in and extract the metadata from the 'package/package.json' contained in it. Use this extracted metadata to fetch the upstream registry's metadata for the given package and then augment the version-specific metadata for version given in the tarball such that it looks like it was recently published. Use shasum to calculate the digest and then pre-seed the paths where nginx will look for the package.json and package-X.Y.Z.tgz so that it doesn't even bother looking upstream for them.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than supporting
npm publish, this feature allows a tarball to be fed as input when the container is started and have that package tarball (and associated metadata) overlayed on top of whatever metadata upstream is providing.To test some local changes as a patch release:
$ npm info .dist-tags.latest 1.2.2 $ npm pack my-package-1.2.3.tgz $ cat my-package-1.2.3.tgz | docker run -i -p 4873:4873 strongloop/ephemeral-npm:nginx ...elsewhere, in a package that depends on
my-package@1.2.xWe can now test unreleased changes as though they had been tested without introducing package linking as a test environment complication.