Fix regression for empty string path in app.use

fixes #2361 fixes #2362
expressjs · Sep 18, 2014 · 3c1a964 · 3c1a964
1 parent 947fb8b
commit 3c1a964
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 1 deletion.
diff --git a/History.md b/History.md
@@ -1,3 +1,8 @@
+unreleased
+==========
+
+  * Fix regression for empty string `path` in `app.use`
+
 4.9.1 / 2014-09-16
 ==================
 

diff --git a/lib/application.js b/lib/application.js
@@ -165,7 +165,8 @@ app.use = function use(fn) {
       arg = arg[0];
     }
 
-    if (typeof arg !== 'function' && (arg == null || arg.length !== 0)) {
+    // first arg is the path
+    if (typeof arg !== 'function') {
       offset = 1;
       path = fn;
     }

diff --git a/test/app.use.js b/test/app.use.js
@@ -503,5 +503,17 @@ describe('app', function(){
       .get('/get/zoo')
       .expect(404, cb);
     })
+
+    it('should support empty string path', function (done) {
+      var app = express();
+
+      app.use('', function (req, res) {
+        res.send('saw ' + req.method + ' ' + req.url + ' through ' + req.originalUrl);
+      });
+
+      request(app)
+      .get('/')
+      .expect(200, 'saw GET / through /', done);
+    })
   })
 })