Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate app.param(name, fn) where name starts with a colon #2430

Closed
dougwilson opened this issue Nov 6, 2014 · 1 comment
Closed

Deprecate app.param(name, fn) where name starts with a colon #2430

dougwilson opened this issue Nov 6, 2014 · 1 comment
Labels
4.x deprecate
Milestone
4.11

Comments

@dougwilson
Copy link
Contributor

Right now, app.param(':id', fn) is equivalent to app.param('id', fn), which I believe is to be able to make the name look like it's the same syntax as in paths. This seems redundant and adds unnecessary complexity, and would be odd if there would someday be a way to use RFC 6570 for URLs.
@Fishrock123
Copy link
Contributor

👍

@Fishrock123 Fishrock123 mentioned this issue Nov 21, 2014
Closed
@Fishrock123 Fishrock123 added this to the 4.11 milestone Nov 21, 2014
dougwilson added a commit that referenced this issue Nov 24, 2014
@dougwilson
Deprecate leading colon in name for app.param
eb8c46e 
closes #2430
@dougwilson dougwilson mentioned this issue Nov 24, 2014
Merged
6 tasks
dougwilson added a commit that referenced this issue Dec 16, 2014
@dougwilson
Deprecate leading colon in name for app.param
83b1e1e 
closes #2430
dougwilson added a commit that referenced this issue Jan 5, 2015
@dougwilson
Deprecate leading colon in name for app.param
f911066 
closes #2430
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
4.x deprecate
Projects
None yet
Milestone
4.11
Development

No branches or pull requests
2 participants
@dougwilson @Fishrock123