Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SlowBuffers are not handled correctly with send. #584

Closed
tyrda01 opened this issue Mar 16, 2011 · 2 comments
Closed

SlowBuffers are not handled correctly with send. #584

tyrda01 opened this issue Mar 16, 2011 · 2 comments

Comments

@tyrda01
Copy link

tyrda01 commented Mar 16, 2011

When using your canvas project, sending a canvas buffer (which is a SlowBuffer in node) results in a json object being sent. The following patch to respond.js appears resolve this issue.

71c71
<       if (Buffer.isBuffer(body)) {

---
>       if (body instanceof Buffer) {
90c90
<     this.header('Content-Length', Buffer.isBuffer(body)

---
>     this.header('Content-Length', body instanceof Buffer
@tj
Copy link
Member

tj commented Mar 17, 2011

Fixed SlowBuffer support. Closed by 5da0163

@tj tj closed this as completed Mar 17, 2011
@tj
Copy link
Member

tj commented Mar 17, 2011

thanks man

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants