Allow setting an array of header values in the response #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make setting multiple header values using an array work as expected. If the header value is an array, coerce the values to strings instead of the entire array. Fixes expressjs#1419.
|
-1 from me, I think arrays for header fields is crazy awkward |
|
What is the accepted way in express to set multiple headers with the same name? It seems like you'd have to fall back to a lower-level API to make it work. I agree it's awkward, but all we're really doing is imitating the underlying response.setHeader behavior with some extra string coercion. |
|
currently other than the special-cased .cookie() you'd have to, but yeah I guess you're right, might as well have something I guess even if it's awkward, it would be nice to have something progressive but something like |
tj
added a commit
that referenced
this pull request
Jan 24, 2013
Allow setting an array of header values in the response
rlidwka
pushed a commit
to rlidwka/express
that referenced
this pull request
Aug 6, 2014
Allow setting an array of header values in the response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make setting multiple header values using an array work as expected.
If the header value is an array, coerce the values to strings instead
of the entire array.
Fixes #1419.