Add Support for Multiple View Folders #2320
Conversation
| @@ -54,14 +54,25 @@ function View(name, options) { | |||
|
|
|||
| View.prototype.lookup = function(path){ | |||
| var ext = this.ext; | |||
|
|
|||
| if (this.root instanceof Array) { | |||
There was a problem hiding this comment.
use Array.isArray, please :)
|
In general I think this is useful. |
|
I believe it should be directed to expressjs/templation instead, express should eventually use that anyway. |
Not necessarily.. |
|
We will accept the PR here and land it where ever it needs to go later. |
dougwilson
force-pushed
the
master
branch
2 times, most recently
from
25b80a9
to
3dca534
Compare
dougwilson
force-pushed
the
master
branch
3 times, most recently
from
91891e3
to
7289171
Compare
dougwilson
force-pushed
the
master
branch
2 times, most recently
from
360b52c
to
6f0302f
Compare
|
This PR still needs to be refactored to remove that fake context thing. I need to get 4.10 out ASAP, so if I don't have time to refactor this tomorrow (and I guess no one updates this PR to address it), then I'll just push it back to 4.11. |
|
Thanks for getting this merged, this feature just saved my life 😀 |
This adds support for supplying an array of view folders in place of a single view folder [string], allowing for a "fallback" folder of views to be overridden by a preferred location, if they exist.