Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the tests and enable Travis CI #53

Merged
merged 2 commits into from Jan 28, 2015
Merged

Fix the tests and enable Travis CI #53

merged 2 commits into from Jan 28, 2015

Conversation

bajtos
Copy link
Contributor

@bajtos bajtos commented Jan 27, 2015

/to @bnoordhuis please review
/cc @pipobscure @es128

test: improve and fix failures
42c1c9d 
Speed up the test execution by making the timeouts shorter (starting
at 500ms instead of 5 seconds).

Fix the failing test by allowing both `created` and `modified` events
for the new file.
@bajtos bajtos changed the title Enable Travis CI + fix the tests Fix the tests and enable Travis CI Jan 27, 2015
@es128
Copy link
Contributor

es128 commented Jan 27, 2015

Since the project is OS X only, this Travis setup isn't going to work. But if you copy chokidar's (https://github.com/paulmillr/chokidar/blob/master/.travis.yml) and remove the -linux entry it should.

@es128
Copy link
Contributor

es128 commented Jan 27, 2015

Remove the script section too to let it just run the default npm test

@bajtos
Copy link
Contributor Author

bajtos commented Jan 27, 2015

Since the project is OS X only, this Travis setup isn't going to work.

Ah, of course, good catch. I'll rework the PR tomorrow.

@es128
Copy link
Contributor

es128 commented Jan 27, 2015

Err, actually leave the script section since it's now interpreted as a C project without any useful defaults, but change its entry to npm test

@es128
Copy link
Contributor

es128 commented Jan 27, 2015

Oh I just remembered: you may also need to contact Travis support to get the OS X build environment enabled for the project.

http://docs.travis-ci.com/user/multi-os/

@bajtos bajtos force-pushed the feature/enable-travis-ci branch 2 times, most recently from 45aff33 to e7742fd Compare January 28, 2015 08:04
@bajtos
Copy link
Contributor Author

bajtos commented Jan 28, 2015

@es128 I have fixed the travis config, PTAL. OSX is not enabled yet, I am waiting for a response from the Travis team.

@es128
Copy link
Contributor

es128 commented Jan 28, 2015

io.js versions may begin bumping quickly enough that you'll just want to specify iojs and get the latest. But we could also wait and see if keeping up with it here turns out to be a hassle.

Otherwise LGTM.

@es128
Copy link
Contributor

es128 commented Jan 28, 2015

🎉 https://travis-ci.org/strongloop/fsevents/builds/48625581

bajtos added a commit that referenced this pull request Jan 28, 2015
@bajtos
Merge pull request #53 from strongloop/feature/enable-travis-ci
5f283de 
Fix the tests and enable Travis CI
@bajtos bajtos merged commit 5f283de into master Jan 28, 2015
@bajtos bajtos deleted the feature/enable-travis-ci branch January 28, 2015 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bajtos @es128