Add support for option to append access_token and userid to successRedirect #223
Conversation
Common code to set access_token and userid cookies in defaultCallback Support cookie options.domain, independent of session.
…erId on successRedirect URL query
Makes this functionality independent of options.session. This was the behaviour only when options.session was false. Adding {Boolean} appendAccessToken to do this is helpful for mobile clients (iOS).
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
kreegr
changed the title
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Can one of the admins verify this patch? |
|
I would love to see this PR merged ! |
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been closed due to continued inactivity. Thank you for your understanding. If you believe this to be in error, please contact one of the code owners, listed in the |
Description
Addresses several open issues with adding support for optionally appending the access_token and userid to the
successRedirectUrl. This is particularly useful when supporting iOS native clients/hybrid applications. In current implementation, it is only possible whenoptions.session !== true.Also, DRYs up common logic in the
defaultCallback, while adding universal support for theoptions.domaincookie property.If these changes are agreeable, I will append this PR with updated tests.
Related issues
Checklist
guide