chore: update CODEOWNERS #1566
Merged
chore: update CODEOWNERS #1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhmlau
requested review from
b-admike,
jannyHou,
virkt25 and
zbarbuto
as code owners
dhmlau
force-pushed
the
update-codeowner
branch
from
78bb438
to
1d3a112
Compare
virkt25
approved these changes
Mar 22, 2018
|
@slnode test please |
b-admike
reviewed
Mar 22, 2018
CODEOWNERS
Outdated
| @@ -3,8 +3,8 @@ | |||
| # the last matching pattern has the most precendence. | |||
|
|
|||
| # Current maintainers | |||
| * @kjdelisle @jannyHou @loay @b-admike @ssh24 @virkt25 @dhmlau @zbarbuto @nitro404 | |||
| * @jannyHou @b-admike @virkt25 @dhmlau @zbarbuto @nitro404 | |||
There was a problem hiding this comment.
can we add @shimks as well?
dhmlau
force-pushed
the
update-codeowner
branch
from
c031691
to
ce49d7c
Compare
b-admike
approved these changes
Mar 22, 2018
virkt25
approved these changes
Mar 22, 2018
shimks
approved these changes
Mar 22, 2018
|
CI is failing but it failed before this change and it is unrelated. Will open a new issue to track the CI failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update
CODEOWNERSto reflect that@kjdelisle @loay @ssh24are no longer active maintainers.