Test coverages for hashed password

[Amir-61]

• Test coverages for hashed password for replaceAttributes
• Test coverages for hashed password for updateAttribute

Connect to strongloop/loopback#2029

Notes:

Connect to #896

#896 needs to be landed before this patch (PR#893)

@bajtos: Please review... Thanks!

[bajtos]

Uff, this is rather difficult to understand. Could you please split the code into smaller steps and save intermediate results into named variables? Something like this:

var hashed = false;
var pos = plain.indexOf('-');
if (pos !== -1) {
  var head = plain.substr(0, pos);
  var tail = plain.substr(pos + 1, plain.length);
  hashed = head.toUpperCase() === tail;
}

if (hashed) return;

this.$password = plain + '-' + plain.toUpperCase();

[bajtos]

Hi @Amir-61, the tests look good in general, I left two minor comments to address. Have you seen the tests fail? I'd like you to check that these new tests would catch the regression which was fixed by dbdf915

[Amir-61]

Thanks @bajtos ,

In case if my comment gets lost: #893 (comment)

I believe #896 needs to be landed first.

Have you seen the tests fail?

Yes without the fix the added test was failing. 👍

Thanks!

[bajtos]

LGTM. Let's get #896 landed first and the re-run the CI builds before landing this one, to make sure they pass.

[Amir-61]

@slnode test please

[Amir-61]

Also back-ported the commit to 2.x; I'm so sorry I forgot to add the PR# for this back-porting; I knew I could do git commit --amend and do git push -f, but I preferred not to do it since it rewrites the git history... I'll make sure I'll add the PR# in the upcoming PRs when back-porting...