Merge 851ccac into 3c37286

examples/hello-world/package.json

@@ -42,6 +42,7 @@
   "devDependencies": {
     "@loopback/build": "^1.0.2",
     "@loopback/testlab": "^1.0.2",
+    "@loopback/tslint-config": "^1.0.0-1",
     "@types/node": "^10.11.2"
   },
   "keywords": [

examples/hello-world/tslint.build.json

@@ -1,4 +1,4 @@
 {
   "$schema": "http://json.schemastore.org/tslint",
-  "extends": ["./node_modules/@loopback/build/config/tslint.build.json"]
+  "extends": ["./node_modules/@loopback/tslint-config/tslint.build.json"]
 }

examples/hello-world/tslint.json

@@ -1,4 +1,4 @@
 {
   "$schema": "http://json.schemastore.org/tslint",
-  "extends": ["./node_modules/@loopback/build/config/tslint.common.json"]
+  "extends": ["./node_modules/@loopback/tslint-config/tslint.common.json"]
 }

examples/log-extension/package.json

@@ -43,6 +43,7 @@
   "devDependencies": {
     "@loopback/build": "^1.0.2",
     "@loopback/testlab": "^1.0.2",
+    "@loopback/tslint-config": "^1.0.0-1",
     "@types/debug": "0.0.30",
     "@types/node": "^10.11.2"
   },

examples/log-extension/tslint.build.json

@@ -1,4 +1,4 @@
 {
   "$schema": "http://json.schemastore.org/tslint",
-  "extends": ["./node_modules/@loopback/build/config/tslint.build.json"]
+  "extends": ["./node_modules/@loopback/tslint-config/tslint.build.json"]
 }

examples/log-extension/tslint.json

@@ -1,4 +1,4 @@
 {
   "$schema": "http://json.schemastore.org/tslint",
-  "extends": ["./node_modules/@loopback/build/config/tslint.common.json"]
+  "extends": ["./node_modules/@loopback/tslint-config/tslint.common.json"]
 }

examples/rpc-server/package.json

@@ -46,6 +46,7 @@
   "devDependencies": {
     "@loopback/build": "^1.0.2",
     "@loopback/testlab": "^1.0.2",
+    "@loopback/tslint-config": "^1.0.0-1",
     "@types/express": "^4.11.1",
     "@types/node": "^10.11.2",
     "@types/p-event": "^1.3.0"

examples/rpc-server/tslint.build.json

@@ -1,4 +1,4 @@
 {
   "$schema": "http://json.schemastore.org/tslint",
-  "extends": ["./node_modules/@loopback/build/config/tslint.build.json"]
+  "extends": ["./node_modules/@loopback/tslint-config/tslint.build.json"]
 }

examples/rpc-server/tslint.json

@@ -1,4 +1,4 @@
 {
   "$schema": "http://json.schemastore.org/tslint",
-  "extends": ["./node_modules/@loopback/build/config/tslint.common.json"]
+  "extends": ["./node_modules/@loopback/tslint-config/tslint.common.json"]
 }

examples/soap-calculator/package.json

@@ -53,6 +53,7 @@
   "devDependencies": {
     "@loopback/build": "^1.0.2",
     "@loopback/testlab": "^1.0.2",
+    "@loopback/tslint-config": "^1.0.0-1",
     "@types/mocha": "^5.0.0",
     "@types/node": "^10.11.2",
     "mocha": "^5.1.1",

examples/soap-calculator/tslint.build.json

@@ -1,4 +1,4 @@
 {
   "$schema": "http://json.schemastore.org/tslint",
-  "extends": ["./node_modules/@loopback/build/config/tslint.build.json"]
+  "extends": ["./node_modules/@loopback/tslint-config/tslint.build.json"]
 }

examples/soap-calculator/tslint.json

@@ -1,4 +1,4 @@
 {
   "$schema": "http://json.schemastore.org/tslint",
-  "extends": ["./node_modules/@loopback/build/config/tslint.common.json"]
+  "extends": ["./node_modules/@loopback/tslint-config/tslint.common.json"]
 }

examples/todo-list/package.json

@@ -50,6 +50,7 @@
     "@loopback/build": "^1.0.2",
     "@loopback/http-caching-proxy": "^1.0.2",
     "@loopback/testlab": "^1.0.2",
+    "@loopback/tslint-config": "^1.0.0-1",
     "@types/lodash": "^4.14.109",
     "@types/node": "^10.11.2",
     "lodash": "^4.17.10"

examples/todo-list/tslint.build.json

@@ -1,4 +1,4 @@
 {
   "$schema": "http://json.schemastore.org/tslint",
-  "extends": ["./node_modules/@loopback/build/config/tslint.build.json"]
+  "extends": ["./node_modules/@loopback/tslint-config/tslint.build.json"]
 }

examples/todo-list/tslint.json

@@ -1,4 +1,4 @@
 {
   "$schema": "http://json.schemastore.org/tslint",
-  "extends": ["./node_modules/@loopback/build/config/tslint.common.json"]
+  "extends": ["./node_modules/@loopback/tslint-config/tslint.common.json"]
 }

examples/todo/package.json

@@ -50,6 +50,7 @@
     "@loopback/build": "^1.0.2",
     "@loopback/http-caching-proxy": "^1.0.2",
     "@loopback/testlab": "^1.0.2",
+    "@loopback/tslint-config": "^1.0.0-1",
     "@types/lodash": "^4.14.109",
     "@types/node": "^10.11.2",
     "lodash": "^4.17.10"

examples/todo/tslint.build.json

@@ -1,4 +1,4 @@
 {
   "$schema": "http://json.schemastore.org/tslint",
-  "extends": ["./node_modules/@loopback/build/config/tslint.build.json"]
+  "extends": ["./node_modules/@loopback/tslint-config/tslint.build.json"]
 }

examples/todo/tslint.json

@@ -1,4 +1,4 @@
 {
   "$schema": "http://json.schemastore.org/tslint",
-  "extends": ["./node_modules/@loopback/build/config/tslint.common.json"]
+  "extends": ["./node_modules/@loopback/tslint-config/tslint.common.json"]
 }

packages/authentication/package.json

@@ -32,6 +32,7 @@
     "@loopback/build": "^1.0.2",
     "@loopback/openapi-spec-builder": "^1.0.2",
     "@loopback/testlab": "^1.0.2",
+    "@loopback/tslint-config": "^1.0.0-1",
     "@types/node": "^10.11.2",
     "@types/passport": "^0.4.4",
     "@types/passport-http": "^0.3.6",

packages/boot/package.json

@@ -37,6 +37,7 @@
     "@loopback/openapi-v3": "^1.1.4",
     "@loopback/rest": "^1.5.0",
     "@loopback/testlab": "^1.0.2",
+    "@loopback/tslint-config": "^1.0.0-1",
     "@types/node": "^10.11.2"
   },
   "files": [

packages/build/README.md

@@ -105,32 +105,33 @@ Now you run the scripts, such as:
   `lb-tslint` also depends on `tsconfig.build.json` or `tsconfig.json` to
   reference the project.
 
+  **NOTE:** Our recommended configuration of tslint rules is maintained inside
+  the package `@loopback/tslint-config`. We strongly recommend users to create
+  their own tslint configuration files inheriting from `@loopback/tslint-config`
+  instead of relying on the defaults provided by `@loopback/build`.
+
   To customize the configuration:
 
   - Create `tslint.build.json` in your project's root directory, for example:
+
     ```json
     {
       "$schema": "http://json.schemastore.org/tslint",
-      "extends": [
-        "./node_modules/@loopback/build/config/tslint.common.json"
-      ],
+      "extends": ["@loopback/eslint-config/tslint.build.json"],
       // This configuration files enabled rules which require type checking
       // and therefore cannot be run by Visual Studio Code TSLint extension
       // See https://github.com/Microsoft/vscode-tslint/issues/70
       "rules": {
         // These rules find errors related to TypeScript features.
-    ```
+        // These rules catch common errors in JS programming or otherwise
+        // confusing constructs that are prone to producing bugs.
 
-```json
-    // These rules catch common errors in JS programming or otherwise
-    // confusing constructs that are prone to producing bugs.
-
-    "await-promise": true,
-    "no-floating-promises": true,
-    "no-void-expression": [true, "ignore-arrow-function-shorthand"]
-  }
-}
-```
+        "await-promise": true,
+        "no-floating-promises": true,
+        "no-void-expression": [true, "ignore-arrow-function-shorthand"]
+      }
+    }
+    ```
 
 - Set options explicitly for the script
 

packages/build/config/tslint.build.json

@@ -1,23 +1,6 @@
 {
   "$schema": "http://json.schemastore.org/tslint",
   "extends": [
-    "./tslint.common.json"
-  ],
-  // This configuration files enabled rules which require type checking
-  // and therefore cannot be run by Visual Studio Code TSLint extension
-  // See https://github.com/Microsoft/vscode-tslint/issues/70
-  "rules": {
-    // These rules find errors related to TypeScript features.
-
-    // These rules catch common errors in JS programming or otherwise
-    // confusing constructs that are prone to producing bugs.
-
-    // User-land promises like Bluebird implement "PromiseLike" (not "Promise")
-    // interface only. The string "PromiseLike" bellow is needed to
-    // tell tslint that it's ok to `await` such promises.
-    "await-promise": [true, "PromiseLike", "RequestPromise"],
-    "no-floating-promises": [true, "PromiseLike", "RequestPromise"],
-    "no-unused-variable": true,
-    "no-void-expression": [true, "ignore-arrow-function-shorthand"]
-  }
+    "@loopback/tslint-config/tslint.build.json"
+  ]
 }

packages/build/config/tslint.common.json

@@ -1,26 +1,6 @@
 {
-  // See https://palantir.github.io/tslint/rules/
-  "rules": {
-    // These rules find errors related to TypeScript features.
-    "adjacent-overload-signatures": true,
-    "prefer-for-of": true,
-    "unified-signatures": true,
-    "no-any": true,
-
-    // These rules catch common errors in JS programming or otherwise
-    // confusing constructs that are prone to producing bugs.
-
-    "label-position": true,
-    "no-arg": true,
-    "no-construct": true,
-    "no-duplicate-variable": true,
-
-    "no-invalid-this": true,
-    "no-misused-new": true,
-    "no-shadowed-variable": true,
-    "no-string-throw": true,
-    "no-unused-expression": true,
-    "no-var-keyword": true,
-    "triple-equals": [true, "allow-null-check", "allow-undefined-check"]
-  }
+  "$schema": "http://json.schemastore.org/tslint",
+  "extends": [
+    "@loopback/tslint-config/tslint.common.json"
+  ]
 }

packages/build/package.json

@@ -13,6 +13,7 @@
   "copyright.owner": "IBM Corp.",
   "license": "MIT",
   "dependencies": {
+    "@loopback/tslint-config": "^1.0.0-1",
     "@types/mocha": "^5.0.0",
     "@types/node": "^10.11.2",
     "cross-spawn": "^6.0.5",
@@ -41,5 +42,8 @@
   "scripts": {
     "test": "npm run mocha",
     "mocha": "node bin/run-mocha --timeout 30000 \"test/integration/*.js\""
+  },
+  "devDependencies": {
+    "@loopback/tslint-config": "^1.0.0-1"
   }
 }

packages/cli/generators/project/templates/package.json.ejs

@@ -92,6 +92,7 @@
   "devDependencies": {
     "@loopback/build": "<%= project.dependencies['@loopback/build'] -%>",
     "@loopback/testlab": "<%= project.dependencies['@loopback/testlab'] -%>",
+    "@loopback/tslint-config": "<%= project.dependencies['@loopback/tslint-config'] -%>",
     "@types/node": "<%= project.dependencies['@types/node'] -%>"
   }
 }

packages/cli/generators/project/templates/tslint.build.json.ejs

@@ -1,4 +1,4 @@
 {
   "$schema": "http://json.schemastore.org/tslint",
-  "extends": ["./node_modules/@loopback/build/config/tslint.build.json"]
+  "extends": ["./node_modules/@loopback/tslint-config/tslint.build.json"]
 }

packages/cli/generators/project/templates/tslint.json.ejs

@@ -1,7 +1,7 @@
 {
   "$schema": "http://json.schemastore.org/tslint",
 <% if (project.loopbackBuild) { -%>
-  "extends": ["./node_modules/@loopback/build/config/tslint.common.json"]
+  "extends": ["./node_modules/@loopback/tslint-config/tslint.common.json"]
 <% } else { -%>
   // See https://palantir.github.io/tslint/rules/
   "rules": {

packages/cli/package.json

@@ -26,6 +26,7 @@
   "devDependencies": {
     "@loopback/build": "^1.0.2",
     "@loopback/testlab": "^1.0.2",
+    "@loopback/tslint-config": "^1.0.0-1",
     "@types/ejs": "^2.6.0",
     "@types/node": "^10.11.2",
     "glob": "^7.1.2",
@@ -112,7 +113,8 @@
       "@loopback/http-server": "^1.1.1",
       "@loopback/example-todo-list": "^1.3.0",
       "@loopback/dist-util": "^0.4.0",
-      "@loopback/rest-explorer": "^1.1.3"
+      "@loopback/rest-explorer": "^1.1.3",
+      "@loopback/tslint-config": "^1.0.0-1"
     }
   },
   "copyright.owner": "IBM Corp.",

packages/cli/test/integration/lib/project-generator.js

@@ -249,7 +249,7 @@ module.exports = function(projGenerator, props, projectType) {
         assert.jsonFileContent('package.json', props);
         assert.fileContent([
           ['package.json', '@loopback/build'],
-          ['tslint.json', '@loopback/build'],
+          ['tslint.json', '@loopback/tslint-config'],
           ['tsconfig.json', '@loopback/build'],
         ]);
         assert.noFileContent([

packages/context/package.json

@@ -26,6 +26,7 @@
   "devDependencies": {
     "@loopback/build": "^1.0.2",
     "@loopback/testlab": "^1.0.2",
+    "@loopback/tslint-config": "^1.0.0-1",
     "@types/bluebird": "^3.5.20",
     "@types/debug": "^0.0.30",
     "@types/node": "^10.11.2",

packages/core/package.json

@@ -25,6 +25,7 @@
   "devDependencies": {
     "@loopback/build": "^1.0.2",
     "@loopback/testlab": "^1.0.2",
+    "@loopback/tslint-config": "^1.0.0-1",
     "@types/node": "^10.11.2"
   },
   "files": [

packages/http-caching-proxy/package.json

@@ -27,6 +27,7 @@
   "devDependencies": {
     "@loopback/build": "^1.0.2",
     "@loopback/testlab": "^1.0.2",
+    "@loopback/tslint-config": "^1.0.0-1",
     "@types/debug": "^0.0.30",
     "@types/node": "^10.11.2",
     "@types/p-event": "^1.3.0",

packages/http-server/package.json

@@ -23,6 +23,7 @@
     "@loopback/build": "^1.0.2",
     "@loopback/core": "^1.1.2",
     "@loopback/testlab": "^1.0.2",
+    "@loopback/tslint-config": "^1.0.0-1",
     "@types/node": "^10.11.2",
     "@types/p-event": "^1.3.0",
     "@types/request-promise-native": "^1.0.15",

packages/metadata/package.json

@@ -26,6 +26,7 @@
   "devDependencies": {
     "@loopback/build": "^1.0.2",
     "@loopback/testlab": "^1.0.2",
+    "@loopback/tslint-config": "^1.0.0-1",
     "@types/debug": "^0.0.30",
     "@types/lodash": "^4.14.106",
     "@types/node": "^10.11.2"

packages/openapi-spec-builder/package.json

@@ -26,6 +26,7 @@
   },
   "devDependencies": {
     "@loopback/build": "^1.0.2",
+    "@loopback/tslint-config": "^1.0.0-1",
     "@types/node": "^10.11.2"
   },
   "files": [

packages/openapi-v3-types/package.json

@@ -11,6 +11,7 @@
   "devDependencies": {
     "@loopback/build": "^1.0.2",
     "@loopback/testlab": "^1.0.2",
+    "@loopback/tslint-config": "^1.0.0-1",
     "@types/node": "^10.11.2"
   },
   "scripts": {

packages/openapi-v3/package.json

@@ -10,6 +10,7 @@
     "@loopback/openapi-spec-builder": "^1.0.2",
     "@loopback/repository": "^1.1.0",
     "@loopback/testlab": "^1.0.2",
+    "@loopback/tslint-config": "^1.0.0-1",
     "@types/debug": "0.0.30",
     "@types/lodash": "^4.14.106",
     "@types/node": "^10.11.2"

packages/repository-json-schema/package.json

@@ -32,6 +32,7 @@
   "devDependencies": {
     "@loopback/build": "^1.0.2",
     "@loopback/testlab": "^1.0.2",
+    "@loopback/tslint-config": "^1.0.0-1",
     "@types/node": "^10.11.2",
     "ajv": "^6.5.0"
   },

packages/repository/package.json

@@ -21,6 +21,7 @@
   "devDependencies": {
     "@loopback/build": "^1.0.2",
     "@loopback/testlab": "^1.0.2",
+    "@loopback/tslint-config": "^1.0.0-1",
     "@types/lodash": "^4.14.108",
     "@types/node": "^10.11.2"
   },

packages/rest-explorer/package.json

@@ -26,6 +26,7 @@
   "devDependencies": {
     "@loopback/build": "^1.0.2",
     "@loopback/testlab": "^1.0.2",
+    "@loopback/tslint-config": "^1.0.0-1",
     "@types/ejs": "^2.6.0",
     "@types/node": "^10.1.1"
   },