perf(repository): prevent multiple array allocation

loopbackio · Oct 16, 2018 · 691981c · 691981c
1 parent 90c4406
commit 691981c
Showing 1 changed file with 11 additions and 7 deletions.
diff --git a/packages/repository/src/query.ts b/packages/repository/src/query.ts
@@ -583,17 +583,21 @@ export class FilterBuilder<MT extends object = AnyObject> {
     } else {
       if (isFilter(constraint)) {
         // throw error if imposed Filter has non-where fields
-        Object.keys(constraint).forEach(key => {
-          if (
-            ['fields', 'order', 'limit', 'skip', 'offset', 'include'].includes(
-              key,
-            )
-          ) {
+        const nonWhereFields = [
+          'fields',
+          'order',
+          'limit',
+          'skip',
+          'offset',
+          'include',
+        ];
+        for (const key of Object.keys(constraint)) {
+          if (nonWhereFields.includes(key)) {
             throw new Error(
               'merging strategy for selection, pagination, and sorting not implemented',
             );
           }
-        });
+        }
       }
       this.filter.where = isFilter(constraint)
         ? new WhereBuilder(this.filter.where).impose(constraint.where!).build()