chore: fix eslint related dev dependencies

loopbackio · Jun 4, 2019 · dfe71db · dfe71db
1 parent c99a65f
commit dfe71db
Show file tree

Hide file tree

Showing 25 changed files with 391 additions and 6 deletions.
diff --git a/bin/sync-dev-deps.js b/bin/sync-dev-deps.js
@@ -26,11 +26,13 @@ async function syncDevDeps() {
     .dependencies;
 
   const deps = [
-    'typescript',
-    'eslint',
     '@typescript-eslint/eslint-plugin',
     '@typescript-eslint/parser',
+    'eslint',
+    'eslint-config-prettier',
     'eslint-plugin-eslint-plugin',
+    'eslint-plugin-mocha',
+    'typescript',
   ];
   const masterDeps = {};
   for (const d of deps) {
@@ -61,7 +63,7 @@ async function syncDevDeps() {
  * @param masterDeps - Master dependencies
  */
 function updatePackageJson(pkgFile, masterDeps) {
-  const data = readJsonFile(pkgFile);
+  const data = readPackageJson(pkgFile);
   const isExample = data.name.startsWith('@loopback/example-');
   const isRoot = data.name === 'loopback-next';
 
@@ -85,17 +87,34 @@ function updatePackageJson(pkgFile, masterDeps) {
     }
   }
   if (!modified) return false;
-  writeJsonFile(pkgFile, data);
+  writePackageJson(pkgFile, data);
   return true;
 }
 
 if (require.main === module) syncDevDeps();
 
-function readJsonFile(filePath) {
+function readPackageJson(filePath) {
   return JSON.parse(fs.readFileSync(filePath, 'utf-8'));
 }
 
-function writeJsonFile(filePath, data) {
+function writePackageJson(filePath, data) {
+  data.dependencies = sortObjectByKeys(data.dependencies);
+  data.devDependencies = sortObjectByKeys(data.devDependencies);
   fs.writeFileSync(filePath, JSON.stringify(data, null, 2) + '\n', 'utf-8');
   console.log('%s has been updated.', filePath);
 }
+
+/**
+ * Sort an object by keys
+ * @param data - An object to be sorted
+ */
+function sortObjectByKeys(data) {
+  if (data == null) return undefined;
+  if (typeof data !== 'object') return data;
+  const keys = Object.keys(data).sort();
+  const result = {};
+  for (const k of keys) {
+    result[k] = data[k];
+  }
+  return result;
+}
diff --git a/examples/context/package-lock.json b/examples/context/package-lock.json
diff --git a/examples/context/package.json b/examples/context/package.json
@@ -47,7 +47,9 @@
     "@typescript-eslint/eslint-plugin": "^1.9.0",
     "@typescript-eslint/parser": "^1.9.0",
     "eslint": "^5.16.0",
+    "eslint-config-prettier": "^4.3.0",
     "eslint-plugin-eslint-plugin": "^2.1.0",
+    "eslint-plugin-mocha": "^5.3.0",
     "typescript": "~3.5.1"
   },
   "keywords": [

diff --git a/examples/express-composition/package-lock.json b/examples/express-composition/package-lock.json
diff --git a/examples/express-composition/package.json b/examples/express-composition/package.json
@@ -63,7 +63,9 @@
     "@typescript-eslint/eslint-plugin": "^1.9.0",
     "@typescript-eslint/parser": "^1.9.0",
     "eslint": "^5.16.0",
+    "eslint-config-prettier": "^4.3.0",
     "eslint-plugin-eslint-plugin": "^2.1.0",
+    "eslint-plugin-mocha": "^5.3.0",
     "typescript": "~3.5.1"
   }
 }
diff --git a/examples/greeter-extension/package-lock.json b/examples/greeter-extension/package-lock.json
diff --git a/examples/greeter-extension/package.json b/examples/greeter-extension/package.json
@@ -51,7 +51,9 @@
     "@typescript-eslint/eslint-plugin": "^1.9.0",
     "@typescript-eslint/parser": "^1.9.0",
     "eslint": "^5.16.0",
+    "eslint-config-prettier": "^4.3.0",
     "eslint-plugin-eslint-plugin": "^2.1.0",
+    "eslint-plugin-mocha": "^5.3.0",
     "typescript": "~3.5.1"
   },
   "dependencies": {

diff --git a/examples/greeting-app/package-lock.json b/examples/greeting-app/package-lock.json
diff --git a/examples/greeting-app/package.json b/examples/greeting-app/package.json
@@ -51,7 +51,9 @@
     "@typescript-eslint/eslint-plugin": "^1.9.0",
     "@typescript-eslint/parser": "^1.9.0",
     "eslint": "^5.16.0",
+    "eslint-config-prettier": "^4.3.0",
     "eslint-plugin-eslint-plugin": "^2.1.0",
+    "eslint-plugin-mocha": "^5.3.0",
     "typescript": "~3.5.1"
   },
   "dependencies": {

diff --git a/examples/hello-world/package-lock.json b/examples/hello-world/package-lock.json
diff --git a/examples/hello-world/package.json b/examples/hello-world/package.json
@@ -48,7 +48,9 @@
     "@typescript-eslint/eslint-plugin": "^1.9.0",
     "@typescript-eslint/parser": "^1.9.0",
     "eslint": "^5.16.0",
+    "eslint-config-prettier": "^4.3.0",
     "eslint-plugin-eslint-plugin": "^2.1.0",
+    "eslint-plugin-mocha": "^5.3.0",
     "typescript": "~3.5.1"
   },
   "keywords": [