Merge 91ed8f4 into 28185b6

loopbackio · Feb 14, 2019 · e739a4b · e739a4b
2 parents 28185b6 + 91ed8f4
commit e739a4b
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 3 deletions.
diff --git a/examples/todo-list/src/repositories/todo-list.repository.ts b/examples/todo-list/src/repositories/todo-list.repository.ts
@@ -40,7 +40,7 @@ export class TodoListRepository extends DefaultCrudRepository<
       'todos',
       todoRepositoryGetter,
     );
-    this.image = this._createHasOneRepositoryFactoryFor(
+    this.image = this.createHasOneRepositoryFactoryFor(
       'image',
       todoListImageRepositoryGetter,
     );

diff --git a/packages/repository/src/__tests__/fixtures/repositories/customer.repository.ts b/packages/repository/src/__tests__/fixtures/repositories/customer.repository.ts
@@ -35,11 +35,11 @@ export class CustomerRepository extends DefaultCrudRepository<
     addressRepositoryGetter: Getter<AddressRepository>,
   ) {
     super(Customer, db);
-    this.orders = this._createHasManyRepositoryFactoryFor(
+    this.orders = this.createHasManyRepositoryFactoryFor(
       'orders',
       orderRepositoryGetter,
     );
-    this.address = this._createHasOneRepositoryFactoryFor(
+    this.address = this.createHasOneRepositoryFactoryFor(
       'address',
       addressRepositoryGetter,
     );

diff --git a/packages/repository/src/repositories/legacy-juggler-bridge.ts b/packages/repository/src/repositories/legacy-juggler-bridge.ts
@@ -244,13 +244,40 @@ export class DefaultCrudRepository<T extends Entity, ID>
     );
   }
 
+  /**
+   * @deprecated
+   * Function to create a constrained hasOne relation repository factory
+   *
+   * @param relationName Name of the relation defined on the source model
+   * @param targetRepo Target repository instance
+   */
   protected _createHasOneRepositoryFactoryFor<
     Target extends Entity,
     TargetID,
     ForeignKeyType
   >(
     relationName: string,
     targetRepoGetter: Getter<EntityCrudRepository<Target, TargetID>>,
+  ): HasOneRepositoryFactory<Target, ForeignKeyType> {
+    return this.createHasOneRepositoryFactoryFor(
+      relationName,
+      targetRepoGetter,
+    );
+  }
+
+  /**
+   * Function to create a constrained hasOne relation repository factory
+   *
+   * @param relationName Name of the relation defined on the source model
+   * @param targetRepo Target repository instance
+   */
+  protected createHasOneRepositoryFactoryFor<
+    Target extends Entity,
+    TargetID,
+    ForeignKeyType
+  >(
+    relationName: string,
+    targetRepoGetter: Getter<EntityCrudRepository<Target, TargetID>>,
   ): HasOneRepositoryFactory<Target, ForeignKeyType> {
     const meta = this.entityClass.definition.relations[relationName];
     return createHasOneRepositoryFactory<Target, TargetID, ForeignKeyType>(