Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spike] Reference a Model/type and add additional constraints #2082

Closed
4 of 6 tasks
dhmlau opened this issue Nov 27, 2018 · 6 comments
Closed
4 of 6 tasks

[Spike] Reference a Model/type and add additional constraints #2082

dhmlau opened this issue Nov 27, 2018 · 6 comments
Assignees
Labels

Comments

@dhmlau
Copy link
Member

dhmlau commented Nov 27, 2018

Timebox to 5 days

Description / Steps to reproduce / Feature proposal

Originated from: #1722

During the discussion with @raymondfeng @bajtos, there were different discussion over the support for partial update, we think a spike is needed.

Acceptance Criteria

  • Read through the discussion and proposals listed in the related issues
  • Build a prototype showing how it can be done
  • Share the spike outcome
    • Put the summary in this issue
    • Host a spike meeting
    • Blog post proposing what to do and involve the community

Related issues

@dhmlau dhmlau added this to the December 2018 Milestone milestone Nov 27, 2018
@nabdelgadir nabdelgadir changed the title [Spike] Partial update (PATCH) over REST [Spike] Reference a Model/type and add additional constraints Nov 29, 2018
@jannyHou
Copy link
Contributor

jannyHou commented Nov 29, 2018

Some notes during the estimation meeting(feel free to edit the comment and rephrase):

Let's do the spike from a more general level, think of the big picture of customizing a model's shape, a few of points to be considered:

  • how to customize the shape of model
  • satisfy different requirements of property
  • apply constraints
  • apply validations
  • given a model and properties defined in it, we may have particular expectation at the rest layer, data persistency layer, etc….come up with a general solution to satisfy different requirements.

@raymondfeng
Copy link
Contributor

I would like to explore the usage of {$ref: 'ref-to-the-original-model-or-type', ...additional properties}

@dhmlau dhmlau removed this from the December 2018 Milestone milestone Dec 3, 2018
@bajtos
Copy link
Member

bajtos commented Dec 4, 2018

  • apply constraints
  • apply validations

Please read through the discussion in #1624, it has many insights relevant for this area.

Personally, I'd prefer to narrow down the scope of this spike and stay focused on the two use cases , otherwise it may take ages to complete:

  • PATCH - all properties are optional,
  • CREATE - id and possibly _rev must not be present

@bajtos
Copy link
Member

bajtos commented Mar 26, 2019

the proposal: #2646

@bajtos
Copy link
Member

bajtos commented Mar 28, 2019

Created the following stories:

@bajtos
Copy link
Member

bajtos commented Mar 28, 2019

Blog post proposing what to do and involve the community

As discussed with @dhmlau, we will provide a summary in the March milestone blog post.

Closing the spike as done 🎉

@bajtos bajtos closed this as completed Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants