Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For controller generator, infer id omitted from the existing model class file #3757

Closed
1 task
jannyHou opened this issue Sep 17, 2019 · 2 comments
Closed
1 task
Labels
developer-experience Issues affecting ease of use and overall experience of LB users feature stale

Comments

@jannyHou
Copy link
Contributor

Suggestion

connect to #2036
This is a follow-up story of PR #3667.
As a quick fix, that PR fixes the controller generator by adding a new prompt isIdOmitted, and creating the corresponding controller class differently.

To improve the user experience, we should infer the id omitted or not from the existing model class, if successes, skip the prompt that asks the same question.

Use Cases

In the controller generator, we should Infer whether id is required from the model class, if successes, skip the prompt that asks the same question.

Acceptance criteria

  • In the controller generator, we infer whether id is required from the model class, if successes, then skip the prompt "is id required". See discussion.
@dhmlau dhmlau added the developer-experience Issues affecting ease of use and overall experience of LB users label Sep 17, 2019
@stale
Copy link

stale bot commented Sep 11, 2020

This issue has been marked stale because it has not seen activity within six months. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository. This issue will be closed within 30 days of being stale.

@stale stale bot added the stale label Sep 11, 2020
@stale
Copy link

stale bot commented Oct 12, 2020

This issue has been closed due to continued inactivity. Thank you for your understanding. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository.

@stale stale bot closed this as completed Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer-experience Issues affecting ease of use and overall experience of LB users feature stale
Projects
None yet
Development

No branches or pull requests

2 participants