You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When we already know it is a REST application, we shouldn't have to add a rest property again to the options object, it is not intuitive.
If, for any reason, we can't bring the server options to the top level, rest should be named too server to be more accurate about what we are dealing with.
I think there was a discussion a while back that one Application can have multiple servers, probably that's why we have this configurations.
cc @raymondfeng
I would like to keep the application config consistent for all Application classes. There are other common properties that can be configured for different types of applications, such as shutdown hooks. Using RestConfig for RestApplication will lose such capabilities.
I think there was a discussion a while back that one Application can have multiple servers, probably that's why we have this configurations.
@dhmlau yes, in case of Application it is understood. However, here we are specifically dealing with RestApplication, which cannot have any more servers. At the same time, I can very well understand where @raymondfeng is coming from.
Currently, the
RestApplication
options object look like this:It should look like this:
When we already know it is a REST application, we shouldn't have to add a
rest
property again to the options object, it is not intuitive.If, for any reason, we can't bring the server options to the top level,
rest
should be named tooserver
to be more accurate about what we are dealing with.The text was updated successfully, but these errors were encountered: