Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fixed broken links to VSCODE documentation #2108

Merged
merged 1 commit into from Dec 3, 2018
Merged

docs: fixed broken links to VSCODE documentation #2108

merged 1 commit into from Dec 3, 2018

Conversation

vvdwivedi
Copy link
Contributor

VSCode Documentation link was broken, fixed that to point to correct URL

bajtos
bajtos approved these changes Dec 3, 2018
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I ran git rebase master && git push --force-with-lease to remove the extraneous commit from the pull request.

@bajtos bajtos merged commit cb57a42 into loopbackio:master Dec 3, 2018
@bajtos
Copy link
Member

bajtos commented Dec 3, 2018

Landed, thank you @vvdwivedi for the contribution!

@vvdwivedi vvdwivedi deleted the dev-docs-fix branch December 3, 2018 16:01
@vvdwivedi
Copy link
Contributor Author

Awesome! Thanks for super supportive community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bajtos bajtos bajtos approved these changes

@raymondfeng raymondfeng Awaiting requested review from raymondfeng

@b-admike b-admike Awaiting requested review from b-admike

@hacksparrow hacksparrow Awaiting requested review from hacksparrow

@jannyHou jannyHou Awaiting requested review from jannyHou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vvdwivedi @bajtos