refactor: removed underscore from protected methods in DefaultCrudRep… #2112
Conversation
clayrisser
requested review from
b-admike,
hacksparrow and
jannyHou
as code owners
| protected _createBelongsToAccessorFor<Target extends Entity, TargetId>( | ||
| relationName: string, | ||
| targetRepoGetter: Getter<EntityCrudRepository<Target, TargetId>>, | ||
| ): BelongsToAccessor<Target, ID> { | ||
| return this.createBelongsToAccessorFor(relationName, targetRepoGetter); |
There was a problem hiding this comment.
Shouldn't it make sense to log the deprecation warning ?
What's the overall project strategy to deal with this ?
There was a problem hiding this comment.
Good question. We don't have a deprecation strategy yet.
I guess the question is how much we want to force our users to update their code.
A slow process:
- Soft deprecations (docs only)
- Hard deprecation (warnings printed at runtime) - maybe wait until the next semver-major?
- API removed (in a semver-major release)
A faster process:
- Hard deprecation (warnings printed at runtime)
- API removed (in a semver-major release)
In the past, we were using the fast process. From what I heard about React, their users love their slower process for API deprecations, maybe we can do the same in LoopBack?
Implementation wise, we have had good experience using depd module for dealing with deprecation warnings in LoopBack 2.x/3.x
There was a problem hiding this comment.
On the second thought, since this is a simple rename that has a trivial upgrade path, I am fine with a hard deprecation from the beginning.
bajtos
force-pushed
the
codejamninja/no-underscore-default-repository
branch
from
b0d1b81
to
ad4d70f
Compare
|
Rebased on top of the latest master, squashed the commits into a single one and slightly improved the commit message. Let's wait for CI results before landing. |
|
Landed 🎉 Thank you @codejamninja for the contribution! ❤️ |
Removed underscore from protected methods
Fixes #2091
Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated