Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: add lb4 relation command #2223

Closed
wants to merge 97 commits into from
Closed

cli: add lb4 relation command #2223

wants to merge 97 commits into from

Conversation

TomerSalton
Copy link

@TomerSalton TomerSalton commented Jan 8, 2019 •
edited by raymondfeng
Loading

add lb4 relation command

Solution for issue #1359: loopback-next supports lb4 relation command.

Checklist

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

feat: cli
af1068f 
add lb4 relation command

Solution for issue #1359: loopback-next supports lb4 relation command.
@TomerSalton
Copy link
Author

Hi @bajtos ,
I just want to mention that I'm working on this issue together with @orshlom (who you assigned to here).

@raymondfeng
Copy link
Contributor

@TomerSalton Thank you for the contribution. Please sign CLA by clicking https://cla.strongloop.com/agreements/strongloop/loopback-next.

@raymondfeng
Copy link
Contributor

To fix the coding style/format issues, run npm run lint:fix before commit.

@bajtos bajtos changed the title feat: cli cli: add lb4 relation command Jan 10, 2019
@bajtos bajtos added feature CLI community contribution Relations Model relations (has many, etc.) labels Jan 10, 2019
SharonItz and others added 7 commits January 21, 2019 16:18
@SharonItz
feat(cli): add lb4 relation cli user input
0a4f195 
solution for issue #1359:loopback-next support lb4 relation command

adding cli relation command
@SharonItz
feat(cli): adding lb4 relation cli model controller and repository files
3231b29 
solution for issue #1359:loopback-next support lb4 relation command
adding new files for lb4 cli relation command
@SharonItz
feat(cli): run npm lint on lb4 relation new files
d6d5bef 
solution for issue #1359:loopback-next support lb4 relation command
after npm run lint:fix
fix(repository): test for commit
e807c9d 
we are testing the commit procedure of CLI relation new command

#2223
CLI relation new feature issue #2223
779f31d
CLI relation new feature issue #2223
f40ec99
CLI relation new feature issue #2223
8046de1
bajtos
bajtos reviewed Jan 29, 2019
View reviewed changes
.idea/inspectionProfiles/Project_Default.xml Outdated
@@ -0,0 +1,9 @@
<component name="InspectionProjectProfileManager">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all .idea file from the commit. In general, I am not a fan of listing different IDEs in our .gitignore, but considering the popularity of JetBrain IDEs, it may be a sensible thing to do.

@raymondfeng @strongloop/loopback-maintainers what's your opinion? We are keeping VS Code settings inside our git repo, should we perhaps promote JetBrains IDEs like IDEA and WebStorm as supported IDEs and version their configuration files too?

See also https://github.com/strongloop/loopback-next/blob/master/docs/site/WEBSTORM.md

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tend to keep IDE settings inside our project, it would be very friendly for beginners to build/test/debug.

@orshlom orshlom mentioned this pull request Feb 4, 2019
Closed
7 tasks
oleg269 and others added 28 commits February 18, 2019 00:24
@oleg269
Added to generator relation setOptions.
5976687
@oleg269
Added src ERROR_NO_MODELS_FOUND to relation/index.js.
c32e0c3
@oleg269
Removed redundant option from class RelationGenerator.
d1f549e
@oleg269
Removed unused variabled.
05cbb28
@oleg269
Added options to relation generator.
f088782
@oleg269
Fixed prompt relation type.
1d7e8b0
@oleg269
Fixed sourceModel and destinationModel prompts.
7452ee5
@oleg269
Fixed relation name prompt.
4cb18a1
@oleg269
Code refactoring.
6372a3a
@oleg269
Moved scaffold function to end of file.
5b6408b
@oleg269
Code refactoring.
ef90b04
@oleg269
Code cleanup.
4c6102d
@oleg269
tslint:fix.
d1d76bb
@oleg269
Removed scaffold function from RelationGenerator class.
fcb260d
@oleg269
Fixed debug string.
deca37a
@oleg269
Fixed error Incorrect Relation Type in relation/index.js:416:23.
f1140e8
@oleg269
removed validation sourceModel and destinationModel is the same.
b34bd6c
@oleg269
Code refactoring.
ada357e
@oleg269
Code refactoring.
bc14a41
@oleg269
Added validation is model exist.
7e824c7
@The-Murdock
feat(cli): test for model relation
ff54feb
@oleg269
npm run lint:fix
e443186
@oleg269
Merge branch 'master' into add-lb4-relation
82f97c0
@oleg269
Removed repositoryRelation.js.
0a6f743
@oleg269
Added check import hasMany to test.
d831b91
@oleg269
npm run lint:fix
539aa18
@oleg269
Added async/await to save module.
c535fa6
@oleg269
Merge branch 'master' into add-lb4-relation
2a5df70
@bajtos
Copy link
Member

bajtos commented Mar 7, 2019

Closing in favor of #2426

@bajtos bajtos closed this Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bajtos bajtos bajtos left review comments

@jannyHou jannyHou jannyHou left review comments

@raymondfeng raymondfeng Awaiting requested review from raymondfeng

Assignees
No one assigned
Labels
CLI feature Relations Model relations (has many, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@TomerSalton @raymondfeng @dhmlau @bajtos @jannyHou @SharonItz @oleg269 @The-Murdock @orshlom