New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(repository-json-schema): enumerate fields #2241
Conversation
23544f3
to
21dc174
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the pull request!
Please rebase your branch to the latest master instead of using merge. git remote add upstream git@github.com:strongloop/loopback-next.git
git pull --rebase upstream master
git push -f |
0ccaa79
to
668eb9b
Compare
@raymondfeng I had to rebase on branch context-watcher for tests to work. What I understood is there is new config for the CI, right ? |
@ghsamm You should NOT rebase to |
@ghsamm Here is what I have to do to rebase your PR against the latest master. git rebase -i HEAD~16 (this opens an editor, you should remove the commits from `context-watcher`)
git remote add upstream git@github.com:strongloop/loopback-next.git
git pull --rebase upstream master
git push -f |
Yes I know, I had a weird bug in travis CI so I had to re-rebase the commit for the build to restart. It worked the second time although it is the same commit !! |
enumerate properties of the Entity in the schema of the fields filter
Landed, thank you for the contribution! |
enumerate properties of the Entity in the schema of the fields filter
Checklist
npm test
passes on your machinepackages/cli
were updatedexamples/*
were updated