Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(repository-json-schema): enumerate fields #2241

Merged
merged 1 commit into from Jan 18, 2019
Merged

Conversation

ghsamm
Copy link
Contributor

@ghsamm ghsamm commented Jan 12, 2019

enumerate properties of the Entity in the schema of the fields filter

Checklist

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

@ghsamm ghsamm changed the title feat(repository-json-schema) enumerate fields feat(repository-json-schema): enumerate fields Jan 12, 2019
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request!

packages/repository-json-schema/src/filter-json-schema.ts Outdated Show resolved Hide resolved
@raymondfeng
Copy link
Contributor

Please rebase your branch to the latest master instead of using merge.

git remote add upstream git@github.com:strongloop/loopback-next.git
git pull --rebase upstream master
git push -f

@ghsamm
Copy link
Contributor Author

ghsamm commented Jan 16, 2019

@raymondfeng I had to rebase on branch context-watcher for tests to work.

What I understood is there is new config for the CI, right ?

@raymondfeng
Copy link
Contributor

@ghsamm You should NOT rebase to context-watcher branch as it's still WIP. Your PR branch should be rebased to master only as it's the target for merge.

@raymondfeng
Copy link
Contributor

@ghsamm Here is what I have to do to rebase your PR against the latest master.

git rebase -i HEAD~16 (this opens an editor, you should remove the commits from `context-watcher`)
git remote add upstream git@github.com:strongloop/loopback-next.git
git pull --rebase upstream master
git push -f

@ghsamm
Copy link
Contributor Author

ghsamm commented Jan 16, 2019

@ghsamm You should NOT rebase to context-watcher branch as it's still WIP. Your PR branch should be rebased to master only as it's the target for merge.

Yes I know, I had a weird bug in travis CI so I had to re-rebase the commit for the build to restart. It worked the second time although it is the same commit !!

enumerate properties of the Entity in the schema of the fields filter
@bajtos
Copy link
Member

bajtos commented Jan 18, 2019

Landed, thank you for the contribution!

@ghsamm ghsamm deleted the dev branch January 18, 2019 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants