Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: automatically organize imports on save in VS Code #2591

Merged
merged 1 commit into from Mar 18, 2019
Merged

chore: automatically organize imports on save in VS Code #2591

merged 1 commit into from Mar 18, 2019

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Mar 15, 2019

With this change in place, VSCode will automatically organize imports on every save, thus keeping imports consistently ordered.

Checklist

馃憠 Read and sign the CLA (Contributor License Agreement) 馃憟

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

@bajtos bajtos added the Internal Tooling Issues related to our tooling and monorepo infrastructore label Mar 15, 2019
@bajtos bajtos self-assigned this Mar 15, 2019
@bajtos bajtos requested a review from a team March 15, 2019 07:33
@bajtos bajtos added this to the March 2019 milestone milestone Mar 15, 2019
b-admike
b-admike approved these changes Mar 15, 2019
View reviewed changes
Copy link
Contributor

@b-admike b-admike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤

@bajtos bajtos merged commit c0db235 into master Mar 18, 2019
@bajtos bajtos deleted the chore/organize-imports-on-save branch March 18, 2019 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raymondfeng raymondfeng raymondfeng approved these changes

@hacksparrow hacksparrow hacksparrow approved these changes

@jannyHou jannyHou jannyHou approved these changes

@b-admike b-admike b-admike approved these changes

@nabdelgadir nabdelgadir nabdelgadir approved these changes

Assignees

@bajtos bajtos

Labels
Internal Tooling Issues related to our tooling and monorepo infrastructore
Projects
None yet
Milestone
March 2019 milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bajtos @raymondfeng @hacksparrow @jannyHou @b-admike @nabdelgadir