fix(cli): keep or escape property names for models #2743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
raymondfeng
force-pushed
the
fix-openapi-cli
branch
3 times, most recently
from
3639388
to
7246313
Compare
We need to maintain the property names as `@property` does not support name customization yet.
raymondfeng
force-pushed
the
fix-openapi-cli
branch
from
7246313
to
d81a351
Compare
nabdelgadir
approved these changes
Apr 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per our discussion at #2722 (comment), we need to maintain the property names as
@propertydoes not support name customization yet.Checklist
馃憠 Read and sign the CLA (Contributor License Agreement) 馃憟
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated馃憠 Check out how to submit a PR 馃憟