Refactor/auth security #3590
Merged
Refactor/auth security #3590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymondfeng
reviewed
Aug 21, 2019
| export const CURRENT_USER = BindingKey.create<UserProfile | undefined>( | ||
| 'authentication.currentUser', | ||
| ); | ||
|
|
There was a problem hiding this comment.
Let's keep AuthenticationBindings.CURRENT_USER as an alias to SecurityBinding.CURRENT_USER:
export const CURRENT_USER = SecurityBindings.CURRENT_USER;There was a problem hiding this comment.
@raymondfeng sure, added it.
raymondfeng
reviewed
Aug 21, 2019
| @@ -13,6 +12,7 @@ import { | |||
| authorize, | |||
| Authorizer, | |||
| } from '../..'; | |||
| import {SecurityBindings, securityId} from '../../../../security'; | |||
There was a problem hiding this comment.
This need to be fixed to use @loopback/security.
6 tasks
jannyHou
changed the title
jannyHou
force-pushed
the
refactor/auth-security
branch
2 times, most recently
from
b20c568
to
07a9c58
Compare
raymondfeng
approved these changes
Aug 26, 2019
jannyHou
force-pushed
the
refactor/auth-security
branch
from
01972ad
to
30a4965
Compare
jannyHou
added a commit
that referenced
this pull request
Sep 5, 2019
BREAKING CHANGE: PR#3590 rewrote type UserProfile, add the missing breaking change tag here to amend the one in #3590
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up PR to update
@loopback/authenticationand@loopback/authorizationto depend on@loopback/securityTasks:
@loopback/authenticationdepends on@loopback/security@loopback/authorizationdepends on@loopback/securityChecklist
馃憠 Read and sign the CLA (Contributor License Agreement) 馃憟
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated馃憠 Check out how to submit a PR 馃憟