feat: add title property to ping response schema definition #4288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymondfeng
approved these changes
Dec 11, 2019
raymondfeng
reviewed
Dec 11, 2019
packages/cli/generators/app/templates/src/controllers/ping.controller.ts.ejs
Outdated
Show resolved
Hide resolved
derdeka
force-pushed
the
derdeka/ping-title
branch
from
0c924c5
to
80f3acb
Compare
raymondfeng
approved these changes
Dec 11, 2019
|
In case you're interested, there is a LoopBack Developer badge for those who made contributions to LoopBack. Please check this out: https://www.ibm.com/services/learning/ites.wss/zz-en?pageType=badges&id=0de05804-8037-4791-ac83-09829b566d51. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add title property to ping response schema definition in order to enable better model
generation by third party tools such as https://github.com/OpenAPITools/openapi-generator .
Without a title property the generator would simply name the ping response as
InlineResponse200. By adding the title property, the tooling can produce a model named after the object title.Similar to #4240
Checklist
馃憠 Read and sign the CLA (Contributor License Agreement) 馃憟
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated馃憠 Check out how to submit a PR 馃憟