New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: simplify middleware-based sequence #6824
docs: simplify middleware-based sequence #6824
Conversation
This comment has been minimized.
This comment has been minimized.
07f7650
to
43a01a6
Compare
This comment has been minimized.
This comment has been minimized.
@mrmodise Thank you for the PR. For sequences, we basically have two styles:
Both sequence are extensible and customizable. The legacy sequence has a middleware action that allows plugging in additional middleware. The new sequence is fully composable from middleware via the extension point/extension pattern. Each style has a base class to be extended for customization. |
Thanks @raymondfeng based on your comments I think even the action-based sequence needs some improvement since the section is mixing a lot of complex topics. Let me do some optimisations there as well. You can review the current changes on middleware-based since thats the one I had targeted |
43a01a6
to
d2b831a
Compare
738dae1
to
4d1ad7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mrmodise, thanks for the PR. I had some minor comments.
For the files to be deleted, I'm wondering if there's an equivalent file for that. If yes, it would be helpful to add redirect_from
in the front matter of the md file (example: https://raw.githubusercontent.com/strongloop/loopback-next/master/docs/site/Accessing-services.md). Thanks.
4d1ad7e
to
ddda96d
Compare
I will double check this |
c134140
to
3ebe64c
Compare
307d543
to
9e936d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work thus far! 馃憤
Sorry I don't have time to fully look through the changes in detail. But this is my initial comments 馃憞
Signed-off-by: mrmodise <modisemorebodi@gmail.com>
9e936d1
to
6ab15cc
Compare
For the pages to be deleted i split the content across other pages PTAL @dhmlau |
I reviewed the new version, no pages are being removed now. Existing links pointing to our docs should keep working after this change. |
Landed, thank you @mrmodise for the contribution! 鉂わ笍 |
Closes #6770
Checklist
npm test
passes on your machinepackages/cli
were updatedexamples/*
were updated馃憠 Check out how to submit a PR 馃憟