Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: tip to intercept all queries #6849

Merged
merged 1 commit into from Dec 16, 2020
Merged

docs: tip to intercept all queries #6849

merged 1 commit into from Dec 16, 2020

Conversation

Quent1Pr
Copy link
Contributor

Share a workaround to intercept all requests

re #6099

Signed-off-by: quentin 31855566+QPierre1@users.noreply.github.com

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

馃憠 Check out how to submit a PR 馃憟

@achrinza
Copy link
Member

achrinza commented Nov 26, 2020 •
edited

Thanks for the pull request! Please refrain from opening duplicate PRa and consider using git rebase and git push --force-with-lease to fix the git history. This would make it easier to keep track of the issue-PR lifecycle and any requested changes.

You can refer to this documentation for more info and tips on submitting PRs:

https://loopback.io/doc/en/lb4/submitting_a_pr.html

achrinza
achrinza requested changes Dec 16, 2020
View reviewed changes
docs/site/Interceptor.md Outdated Show resolved Hide resolved
@Quent1Pr @achrinza
docs: tip to intercept all queries
4e204b1 
Share a workaround to intercept all requests

re loopbackio#6099

Signed-off-by: quentin <31855566+QPierre1@users.noreply.github.com>
Co-authored-by: Rifa Achrinza <25147899+achrinza@users.noreply.github.com>
achrinza
achrinza approved these changes Dec 16, 2020
View reviewed changes
Copy link
Member

@achrinza achrinza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @QPierre1! I've went ahead and tidied the commit history. Could you please confirm that everything (such as the DCO sign-off, changes) is correct?

@Quent1Pr
Copy link
Contributor Author

Yes

@achrinza achrinza merged commit ff4f4cc into loopbackio:master Dec 16, 2020
@achrinza
Copy link
Member

Thanks for the Pull Request! It's been merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achrinza achrinza achrinza approved these changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Quent1Pr @achrinza @dhmlau