Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix docs formatting #6936

Merged
merged 1 commit into from Dec 23, 2020

Conversation

achrinza
Copy link
Member

supersedes #6441

Signed-off-by: Rifa Achrinza 25147899+achrinza@users.noreply.github.com

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

馃憠 Check out how to submit a PR 馃憟

Copy link
Contributor

@nabdelgadir nabdelgadir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR LGTM, but would it be possible to add the original contributor as a co-author? If it'll cause DCO issues then this looks good to land as is 馃憤

Co-authored-by: Ibukun Dairo <ibukundairo@hackerbay.io>
Signed-off-by: Rifa Achrinza <25147899+achrinza@users.noreply.github.com>
@dhmlau dhmlau merged commit f0c8532 into loopbackio:master Dec 23, 2020
@achrinza achrinza deleted the chore/fix-docs-formatting branch December 25, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants