Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loopback creates a domain with no error handler #1787

Closed
priyavivek1 opened this issue Oct 30, 2015 · 1 comment
Closed

Loopback creates a domain with no error handler #1787

priyavivek1 opened this issue Oct 30, 2015 · 1 comment

Comments

@priyavivek1
Copy link

It does that here:

var currentDomain = domain.create();

And that's a problem, because node doesn't invoke the uncaughtException handler when a Domain error goes uncaught. See nodejs/node#3607.

Loopback should have a reasonable default error handler, or provide me with an API to install one.

cc @piscisaureus

@ironbuzz-ilya
Copy link

Domains are deprecated according to the Node.js docs - https://nodejs.org/api/domain.html.

Will Loopback implement an alternative? We are using domains to pass request into entity classes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants