-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unknown signal: null error with Node 8 #143
Comments
Actually no redis needed. Procfile can be |
@ilkkao i had the same issue when upgrading to node 8 yesterday. i haven't had a chance to really dig into the issue and what exactly changed in node 8 (there were some updates to child process kill signals), but the issue seems to be that the event emitter in child.on('exit', function(code, signal) {
emitter.emit('killall', signal);
}); it's passing |
@sdalezman Have you looked into this yet or made any progress? |
+1. Happening for me on Node v8.1.4 on MacOS 10.12.5. |
+1 |
@mitchellporter i haven't had a chance to dig into why it started happening in node 8. but it seems to be that throughout to be honest, i probably don't have time to open a pr this week to fix it but will try to this weekend. |
@slnode can you please confirm to move forward with a pr patch that updates https://nodejs.org/api/child_process.html#child_process_event_exit |
+1 |
I had this problem and made a quick hack -- this has no tests and probably has other problems that don't matter for my use case, but might be useful if you are having the same problem: lightboard@a3982bc |
I'm getting the same (similar) error. How to solve it? Any progress?
|
Using foreman for the first time I spent quite some time debugging my code until I finally found this issue stating that it is not my code but rather foreman and node 8. Seing that this issue is five months old I will have to find a way not to use foreman. |
To make the issue more clear: My code contains lots of async functions. And they will not work in node < v8. |
This issue still has not been addressed. Can someone please address this issue? |
The last commit was in August 2016. Seems like this code is not getting a lot of love any more :-( |
@davidmfoley I finally tried your fix. And it works great! Please go get a beer. |
https://github.com/heroku/node-foreman also works |
I have same problem on all Windows versions, but on the Linux it works. But if I use tasks separately then this tasks works
|
Should be fixed in |
I'm still running into this issue on Node 8.11.1 and using foreman@3.0.0 😢 |
I started to see this error when I upgraded to Node 8. Steps to repro on Mac:
brew install redis
Procfile:
redis: redis-server
nf
(and then CONTROL-C)The text was updated successfully, but these errors were encountered: