foreman causes error on heroku local w/ null signal value

[sdalezman]

there's a bug in node foreman that's caused by event listeners that it passes a null signal value . i'm not sure exactly when this bug was triggered when running heroku local, but it coincided when i upgraded to node 8 (it's also possible i updated heroku at the same time).

the bug can be seen in lines 49-51 in proc.js of node-foreman. the bug occurs when signal is passed and is a null value. this is easy for me to fix locally because I can override the heroku cli node-foreman code. However my ci environment (circleci) comes packaged with the heroku toolchain and would prefer not to have fork a bunch of libs to have it work correctly.

[jdx]

hrm we may ultimately have to fork the project and maintain it ourselves if we don't see any activity there

[Komsomol]

I have the same error occur on node v6.11.0

internal/util.js:183
  throw new errors.Error('ERR_UNKNOWN_SIGNAL', signal);
  ^

Error [ERR_UNKNOWN_SIGNAL]: Unknown signal: null
    at convertToValidSignal (internal/util.js:183:9)
    at ChildProcess.kill (internal/child_process.js:381:5)
    at EventEmitter.<anonymous> (/Users/farhad/.local/share/heroku/client/node_modules/foreman/lib/proc.js:54:11)
    at emitOne (events.js:120:20)
    at EventEmitter.emit (events.js:210:7)
    at ChildProcess.<anonymous> (/Users/farhad/.local/share/heroku/client/node_modules/foreman/lib/proc.js:50:13)
    at emitTwo (events.js:125:13)
    at ChildProcess.emit (events.js:213:7)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)

[RasPhilCo]

Follow heroku/heroku-local#36 && heroku/node-foreman#1

[RasPhilCo]

Closed via ce0aa10