WIP: Upgrade all outdated dependencies #117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This makes them compatible with node-tap 1.x and newer.
For chai heavy tests, simply wrap them in a t.doesNotThrow(), but for plain assertion tests, refactor them to use TAP's assertions.
The usage was so minor that it is easier to just remove it entirely than to upgrade to a recent version.
node-foreman's builtin logging interfers with certain TAP parsers, resulting in a passing test suite that shows up as a failed build.
Not all versions of node on all platforms properly give a signal with the 'exit' event. This is likely causing the tests to be a little flaky on Windows under node 0.10.
The first argument was originally supposed to be the expected exit code, but these tests assumed it would default to 0 if not specified. Now it does.
Switch to TAP output for easier debugging and disable coverage reporting.
As a side effect, this also allows nyc to generate more accurate coverage reports :-)
The test setup is based on the behaviour described in #93, but with the required modifications to support testing without using any fixed ports.
rmg
force-pushed
the
upgrade-all-the-things
branch
from
3f74b93
to
13b92b9
Compare
It is the most likely to fail, so better for failing fast with this ordering.
|
Closing as abandoned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chaientirely instead of upgrading it