Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only raise a warning, not an error for privileged ports #168

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Only raise a warning, not an error for privileged ports #168

wants to merge 1 commit into from

Commits on Aug 2, 2021

  1. Only raise a warning for privileged port binds 

    On MacOS (and on Linux if using authbind) you don't actually need
to use sudo to bind to ports < 1024, so node-foreman does not need
to raise an error if that happens. Since we can't detect if this
system will or will not require sudo we can just raise a warning.

Signed-off-by: Matthew Allan <matt@mattallan.me>
    @matt-allan
    matt-allan committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    8b87e97 View commit details
    Browse the repository at this point in the history