Fix build failure do to output from prepublish scripts #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the pack file path detection to look at the end of the output to avoid be confused by output from prepublish scripts.
jtary
force-pushed
the
fix/npm-prepublish-output
branch
from
35f31d0
to
f50a911
Compare
|
|
||
| // the pack filename should be on the second to last line of the output. | ||
| if (outputLines.length > 1) { | ||
| return null; //outputLines[outputLines.length - 2]; |
|
I wonder if instead of trying to parse the output to get the name we should just check the exit code and then generate the filename ourselves using the name and version from the |
|
I agree, there isn't any reason to parse the packfile name from npm build output. |
|
@jtary thanks for finding this, I hope it wasn't too horrible to track down. I'll get this fixed, but use the non-parsing approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the pack file path detection to look at the end of the output to
avoid be confused by output from prepublish scripts.
connect to strongloop-internal/scrum-nodeops#766