Modify RestAdapter to allow disabling errorHandler

[digitalsadhu]

options.handleErrors = false will allow the RestAdapter error handler
to be bypassed

See: strongloop/loopback#445 (comment) for discussion

@bajtos does this look ok?

[slnode]

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

[listepo]

👍

[bajtos]

@slnode ok to test

[bajtos]

Hi @digitalsadhu, thank you for the pull request. Could you please add some unit-tests to verify the implementation and prevent regressions in the future? See f26a871 for an inspiration.

[digitalsadhu]

@bajtos tests added, still seeing failing checks there. Not sure how I would resolve those as tests are all passing for me. Can you point me in the right direction?

[bajtos]

LGTM.

@ritch would you like to take a look at this change yourself too?

still seeing failing checks there. Not sure how I would resolve those as tests are all passing for me. Can you point me in the right direction?

Those test failures are in projects that are using strong-remoting as a dependency. I think it's the loopback-example-oracle repository that is failing unit-tests because the oracle driver does not support Node v4.x yet.

@rmg any ideas how to fix this false alert?

@digitalsadhu don't worry about those dependent builds, I am ok to land the PR with loopback-example-oracle failing. Could you please squash the commits into a single one?

[digitalsadhu]

@bajtos Squashed

[bajtos]

@digitalsadhu a nitpick, could you please fix the commit message to use the correct option name options.handleErrors (plural, not singular)?

[bajtos]

I asked @ritch to review and land this, I am on vacation tomorrow.

[digitalsadhu]

@bajtos @ritch Oops, fixed commit message now.

[rmg]

@bajtos they aren't warnings, the loopback-example-recipes module has a hard dependency on loopback-connector-oracle :-( I've opened an issue for it: strongloop/loopback-example-recipes#8

[digitalsadhu]

@bajtos how are we looking?

[bajtos]

@digitalsadhu thanks for the reminder. Since @ritch has not commented, I'll assume he does not have any major objections.

Landed, thank you for the valuable contribution!

[ritch]

👍

[digitalsadhu]

Yay! Thanks guys.

On Wed, 21 Oct 2015 at 15:33, Ritchie Martori notifications@github.com
wrote:

[image: 👍]

—
Reply to this email directly or view it on GitHub
#248 (comment)
.

[bajtos]

Released to npmjs.org as strong-remoting@2.22.0

[bajtos]

Enjoy :)

[crandmck]

@digitalsadhu I'd like to add this to the API documentation on https://apidocs.strongloop.com/strong-remoting/ but I'm not sure where it should go. Can you give me a pointer?

[bajtos]

@crandmck I think here is a better place where to document this new feature: https://docs.strongloop.com/display/LB/config.json?src=search#config.json-Remotingproperties

The property name is rest.handleErrors.

While you are at it, could you please document rest.handleUnknownPaths too? It was added by f26a871.

[crandmck]

@bajtos Thank you, that does make more sense.

I added both those properties to https://docs.strongloop.com/display/LB/config.json#config.json-Remotingproperties. In particular, the descriptions could perhaps have a bit more... PTAL.

[digitalsadhu]

Nice!
1 thing though, typo: "handleErros" : true,

[crandmck]

Doh! Thanks for catching--fixed...

[bajtos]

@crandmck I have added a bit more info, PTAL.

[crandmck]

Thanks again @bajtos