-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix query string to have null #378
Conversation
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
Can one of the admins verify this patch? |
2 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
@slnode test please |
Just a side note: In LB3.x we have worked on coercion and made both conversion and coercion more strict. null value is accepted only for "object", "array" and "any". |
I think this will be fixed with: #325 |
@kobaska : Thank you for your pull request. PR# 325, as mentioned by @horiaradu, addresses the same issue and it is ready to land. Re. your PR, please see the comments here: #325 (comment) For future reference, please add test cases along with your code to get the PR review started. See the code contribution guidelines for LoopBack here. Closing in favor of #325. |
cc/ @Amir-61 |
@gunjpan Yep will do, thanks :) |
Fix to allow query string to have null. At the moment doing a find such as below would not work as qs.stringify function would remove the null from the query.
SomeModel.find({where: {name: null}});
Instead using JSON.stringify with encodeURI