Update client.js to add RPC suffixes #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimveasna
changed the title
kimveasna
force-pushed
the
master
branch
3 times, most recently
from
f6af2eb
to
570e4c7
Compare
|
@kimveasna , thank you for the fix. |
emonddr
approved these changes
Mar 23, 2020
deepakrkris
reviewed
Mar 23, 2020
| @@ -333,7 +333,7 @@ class Client extends Base { | |||
| result = obj.Body[outputName]; | |||
| } | |||
| if (!result) { | |||
There was a problem hiding this comment.
some how there are two if blocks implementing the same condition
along with the changes in this PR we could fix the first block with the regex as well
(?:(Out|\.Out)(?:put)?|(Response|\.Response))$
deepakrkris
approved these changes
Mar 23, 2020
| @@ -333,7 +333,7 @@ class Client extends Base { | |||
| result = obj.Body[outputName]; | |||
There was a problem hiding this comment.
we can fix the previous regex block as well :
(?:(Out|\.Out)(?:put)?|(Response|\.Response))$
|
@kimveasna , please squash your commits. e.g. |
Thank you for the instructions. All done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional RPC suffixes are appended to manage SOAP RFC from SAP auto-generated webservices.
Related issues
Checklist
guide