runctl: allow cluster size to be set to CPUs #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -100,6 +102,14 @@ tap.test('runctl via clusterctl', function(t) { | |||
| }, 'status worker id 6'); | |||
|
|
|||
| t.doesNotThrow(function() { | |||
| expect('set-size CPUs'); | |||
There was a problem hiding this comment.
Should do a set-size 0 before this, otherwise the test isn't valid if it happens to run on a 2 core system (quite possible in CI environments).
|
Other than a corner case in the test assumptions, LGTM. |
|
Build failing for a real bug in 0.12. I'm fixing in strongloop/strong-cluster-control#52, and will merge this because its needed for docker. |
Command line and environment variable parsing supported a cluster size of "cpus", but the set-size command did not, now it does.
sam-github
force-pushed
the
support-set-size-of-cpus
branch
from
de77402
to
496353c
Compare
sam-github
added a commit
that referenced
this pull request
May 20, 2015
runctl: allow cluster size to be set to CPUs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Command line and environment variable parsing supported a cluster size
of "cpus", but the set-size command did not, now it does.