Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix shrinkwrap and clean up docs #62

Merged
merged 7 commits into from
Jun 24, 2016
Merged

fix shrinkwrap and clean up docs #62

merged 7 commits into from
Jun 24, 2016

Conversation

rmg
Copy link
Member

@rmg rmg commented Jun 1, 2016

Addresses a couple bugs reported as comments on #56.

rmg added 3 commits June 1, 2016 15:57
Since a bunch of the commands are now returning Promises, make the outer
wrapper Promise-aware so that we can set appropriate exit codes when we
fail.
@sam-github
Copy link
Contributor

can you add docs for slt-release, too, please

@rmg
Copy link
Member Author

rmg commented Jun 3, 2016

This PR doesn't affect slt-release, so I'm not sure what you want added. The slt-release -h output is also already current.

@sam-github
Copy link
Contributor

slt-release docs are not current - they don't mention the new behaviour you added to merge back to master without merging shrinkwrap

slt -h and the README doesn't mention slt shrinkwrap at all (unless that changed in this PR, but I see no signs of it in the diff)

rmg added 2 commits June 21, 2016 13:13
This was added in d1ffb20 but without
adequate documentation around the non-obvious behaviour.
@rmg
Copy link
Member Author

rmg commented Jun 24, 2016

@slnode test please

@rmg rmg changed the title Fix shrinkwrap fix shrinkwrap and clean up docs Jun 24, 2016
@rmg rmg merged commit 35d3ed2 into master Jun 24, 2016
@rmg rmg deleted the fix-shrinkwrap branch June 24, 2016 17:26
@rmg rmg removed the #wip label Jun 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants